Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib-dynamodb): input types conflicts with client-dynamodb #6683

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix(lib-dynamodb): input types conflicts with client-dynamodb #6683

merged 2 commits into from
Nov 20, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 20, 2024 •
edited
Loading

edit of #6676 with codegen changes applied

monholm and others added 2 commits November 19, 2024 17:53
@monholm
fix(lib-dynamodb): input types conflicts with client-dynamodb
ccc521c 
aws#6654 added `| undefined` to optional model props, but the types in lib-dynamodb wasn't updated to
reflect that change. This leaves consumers using `exactOptionalPropertyTypes: true` with ts errors
when trying to use almost any of the commands in lib-dynamodb

Fixes aws#6668
@kuhe
fix(lib-dynamodb): support exactOptionalPropertyTypes
87b1628
@kuhe kuhe requested a review from a team as a code owner November 20, 2024 18:46
@kuhe kuhe changed the title lib dynamodb conflicting input types fix(lib-dynamodb): input types conflicts with client-dynamodb Nov 20, 2024
@kuhe kuhe mentioned this pull request Nov 20, 2024
Closed
@kuhe kuhe merged commit fb0e14e into aws:main Nov 20, 2024
5 checks passed
@kuhe kuhe deleted the lib-dynamodb-conflicting-input-types branch November 20, 2024 20:07
@kuhe kuhe mentioned this pull request Nov 20, 2024
Closed
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zshzbh zshzbh zshzbh approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuhe @trivikr @zshzbh @monholm