Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib-dynamodb): add util-dynamodb to dependencies #2768

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Resolves: #2758
Follow up: #2516

Description

Move @aws-sdk/util-dynamodb to @aws-sdk/lib-dynamobd's production dependency.

Testing

  • Unit test;
  • Local publish, install and validate:
import { DynamoDBClient } from "@aws-sdk/client-dynamodb"; // ES6 import
import { DynamoDBDocumentClient, PutCommand } from "@aws-sdk/lib-dynamodb"; // ES6 import

// Bare-bones DynamoDB Client
const client = new DynamoDBClient({});
const ddbDocClient = DynamoDBDocumentClient.from(client);

(async (): Promise<void> => {
  await ddbDocClient.send(
    new PutCommand({
      TableName: "table",
      Item: {
        id: "1",
        content: "content from DynamoDBDocumentClient",
      },
    })
  );
})();

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2768 (6cc134b) into main (6e8ddd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2768   +/-   ##
=======================================
  Coverage   60.12%   60.12%           
=======================================
  Files         548      548           
  Lines       28559    28559           
  Branches     6990     6990           
=======================================
  Hits        17172    17172           
  Misses      11387    11387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8ddd7...6cc134b. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit b09ba9a into aws:main Sep 10, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-sdk/lib-dynamodb import from @aws-sdk/util-dynamodb but doesn’t include it in dependencies
3 participants