fix: node-http-handler tests which require NODE_TLS_REJECT_UNAUTHORIZED=0

[trivikr]

While updating jest v20->v24 in #243, some node-http-handler tests were commented out to unblock Jest upgrade

aws-sdk-js-v3/packages/node-http-handler/src/node-http-handler.spec.ts

Lines 79 to 233 in 1e156ab

	/*it("can send https requests", async () => {
	const mockResponse = {
	statusCode: 200,
	headers: {},
	body: "test"
	};
	mockHttpsServer.addListener(
	"request",
	createResponseFunction(mockResponse)
	);
	const nodeHttpHandler = new NodeHttpHandler();
	let response = await nodeHttpHandler.handle(
	{
	hostname: "localhost",
	method: "GET",
	port: mockHttpsServer.address().port,
	protocol: "https:",
	path: "/",
	headers: {}
	},
	{}
	);
	expect(response.statusCode).toEqual(mockResponse.statusCode);
	expect(response.headers).toBeDefined();
	expect(response.headers).toMatchObject(mockResponse.headers);
	expect(response.body).toBeDefined();
	});
	it("can send requests with bodies", async () => {
	const body = Buffer.from("test");
	const mockResponse = {
	statusCode: 200,
	headers: {}
	};
	mockHttpsServer.addListener(
	"request",
	createResponseFunction(mockResponse)
	);
	const spy = jest.spyOn(https, "request").mockImplementationOnce(() => {
	let calls = spy.mock.calls;
	let currentIndex = calls.length - 1;
	return https.request(calls[currentIndex][0], calls[currentIndex][1]);
	});
	const nodeHttpHandler = new NodeHttpHandler();
	let response = await nodeHttpHandler.handle(
	{
	hostname: "localhost",
	method: "PUT",
	port: mockHttpsServer.address().port,
	protocol: "https:",
	path: "/",
	headers: {},
	body
	},
	{}
	);
	expect(response.statusCode).toEqual(mockResponse.statusCode);
	expect(response.headers).toBeDefined();
	expect(response.headers).toMatchObject(mockResponse.headers);
	});
	it("can handle expect 100-continue", async () => {
	const body = Buffer.from("test");
	const mockResponse = {
	statusCode: 200,
	headers: {}
	};
	mockHttpsServer.addListener(
	"checkContinue",
	createContinueResponseFunction(mockResponse)
	);
	let endSpy: jest.SpyInstance<any>;
	let continueWasTriggered = false;
	const spy = jest.spyOn(https, "request").mockImplementationOnce(() => {
	let calls = spy.mock.calls;
	let currentIndex = calls.length - 1;
	const request = https.request(
	calls[currentIndex][0],
	calls[currentIndex][1]
	);
	request.on("continue", () => {
	continueWasTriggered = true;
	});
	endSpy = jest.spyOn(request, "end");
	return request;
	});
	const nodeHttpHandler = new NodeHttpHandler();
	let response = await nodeHttpHandler.handle(
	{
	hostname: "localhost",
	method: "PUT",
	port: mockHttpsServer.address().port,
	protocol: "https:",
	path: "/",
	headers: {
	Expect: "100-continue"
	},
	body
	},
	{}
	);
	expect(response.statusCode).toEqual(mockResponse.statusCode);
	expect(response.headers).toBeDefined();
	expect(response.headers).toMatchObject(mockResponse.headers);
	expect(endSpy!.mock.calls.length).toBe(1);
	expect(endSpy!.mock.calls[0][0]).toBe(body);
	expect(continueWasTriggered).toBe(true);
	});
	it("can send requests with streaming bodies", async () => {
	const body = new ReadFromBuffers({
	buffers: [
	Buffer.from("t"),
	Buffer.from("e"),
	Buffer.from("s"),
	Buffer.from("t")
	]
	});
	let inputBodySpy = jest.spyOn(body, "pipe");
	const mockResponse = {
	statusCode: 200,
	headers: {}
	};
	mockHttpsServer.addListener(
	"request",
	createResponseFunction(mockResponse)
	);
	const nodeHttpHandler = new NodeHttpHandler();
	let response = await nodeHttpHandler.handle(
	{
	hostname: "localhost",
	method: "PUT",
	port: mockHttpsServer.address().port,
	protocol: "https:",
	path: "/",
	headers: {},
	body
	},
	{}
	);
	expect(response.statusCode).toEqual(mockResponse.statusCode);
	expect(response.headers).toBeDefined();
	expect(response.headers).toMatchObject(mockResponse.headers);
	expect(inputBodySpy.mock.calls.length).toBeTruthy();
	});*/

These tests need to be fixed

[alexforsyth]

Need to see if jest 26 fixes this issue

[github-actions]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[github-actions]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.