Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): use TS 3.4 compatible types for TS 3.9 #1978

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 29, 2021

Issue

Fixes: #1977

Description

Use TS 3.4 compatible types for TS 3.9

Testing

Verified that build error is not thrown with TS 3.9 by importing package from the workspace with the fix using the following code:

index.ts
import { S3 } from "../aws-sdk-js-v3/clients/client-s3";

(async () => {
  const region = "us-west-2";
  const client = new S3({ region });
  await client.listBuckets({});
})();

Additional context

Follow-up to smithy-lang/smithy-typescript#266


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 070c1e9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP self-requested a review January 29, 2021 18:09
@trivikr trivikr merged commit 8bced5c into aws:master Jan 29, 2021
@trivikr trivikr deleted the downlevel-types-for-ts-3.9 branch January 29, 2021 18:59
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App build breaking with error TS1005 when using TypeScript 3.9.7
3 participants