Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Error: not implemented" in React Native environment #1867

Closed
trivikr opened this issue Jan 5, 2021 · 3 comments · Fixed by #1903 or smithy-lang/smithy-typescript#265
Closed

"Error: not implemented" in React Native environment #1867

trivikr opened this issue Jan 5, 2021 · 3 comments · Fixed by #1903 or smithy-lang/smithy-typescript#265
Assignees
@AllanZhengYP
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 5, 2021 •
edited
Loading

Describe the bug
Aws SDK for JavaScript v3 throws "Error: not implemented" when run in React Native environment.

SDK version number
3.1.0

Is the issue in the browser/Node.js/ReactNative?
React Native

Details of the browser/Node.js/ReactNative version
0.63.4

To Reproduce (observed behavior)
Run React Native set up from https://github.com/aws-samples/aws-sdk-js-tests#react-native
The error is thrown in Emulator output.

Expected behavior
The output is displayed under JS SDK v3

Screenshots

Browser

Screen Shot 2021-01-05 at 10 11 51 AM

React Native Screen Shot 2021-01-05 at 9 45 38 AM
@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2021
@AllanZhengYP AllanZhengYP removed their assignment Jan 12, 2021
@AllanZhengYP
Copy link
Contributor

It has something to do with the #1766. The URL.get() from is not supported in ReactNative. The SDK needs to fall back the JS implementation.
Screen Shot 2021-01-12 at 12 38 16 AM

@AllanZhengYP AllanZhengYP mentioned this issue Jan 12, 2021
Closed
@AllanZhengYP AllanZhengYP removed the needs-triage This issue or PR still needs to be triaged. label Jan 12, 2021
@AllanZhengYP AllanZhengYP self-assigned this Jan 12, 2021
This was referenced Jan 13, 2021
Merged
Merged
@trivikr
Copy link
Member Author

trivikr commented Jan 15, 2021 •
edited
Loading

Verified that JS SDK v3 call is successful in React Native environment with v3.3.0 in aws-samples/aws-sdk-js-tests#66

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AllanZhengYP AllanZhengYP

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
2 participants
@AllanZhengYP @trivikr