Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): skip awsAuthPlugin when optionalAuth trait is set #1622

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 26, 2020

Issue #, if available:
Fixes: #1414

Description of changes:
skip awsAuthPlugin when optionalAuth trait is set for an operation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title fix(codegen): skip awsAuthPlugin when optionalAuth trait is set for an operation fix(codegen): skip awsAuthPlugin when optionalAuth trait is set Oct 26, 2020
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trivikr trivikr merged commit 785272b into aws:master Oct 27, 2020
@trivikr trivikr deleted the support-optionalAuth branch October 27, 2020 18:26
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CognitoIdentityProviderClient incorrectly requires credentials.
3 participants