Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tsconfig provided by smithy-typescript, and extend root TSConfig while running generate-clients #1307

Closed
trivikr opened this issue Jun 29, 2020 · 4 comments
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Jun 29, 2020

Is your feature request related to a problem? Please describe.
The PR #1297 creates root TSConfig for packages/*, but it doesn't apply to clients/* as the clients generated by smithy-typescript should be able to work independently. They need not be part of a monorepo setup.

Because of this, the internal dependencies are not navigable in clients as shown in the screenshot

Screenshot

config-resolver-not-found-client

Describe the solution you'd like

Let smithy-typescript emit tsconfig as it wants, but it should be overriden to extend root TSConfig by generate-clients command.

Describe alternatives you've considered
Sticking with individual TSConfig files for clients

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Jun 29, 2020
@trivikr trivikr closed this as completed Oct 14, 2020
@trivikr trivikr reopened this Oct 14, 2020
@trivikr
Copy link
Member Author

trivikr commented Oct 14, 2020

Closed by mistake.

smithy-typescript will emit a separate TSConfig, as clients should be able to work on their own in an independent repository. The ask is to use central TSConfig in aws-sdk-js-v3 monorepo.

@trivikr

This comment has been minimized.

@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Apr 16, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

1 participant