Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add S3Client reflection hint #5531

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

klopfdreh
Copy link
Contributor

Motivation and Context

Fixes: #5530

Modifications

Added reflection-config.json to software.amazon.awssdk:s3

Testing

Build a GraalVM native image with AWS SDK V2 for Java and AWS CRT Java and run it. The native image will fail with the error described in the issue. If you add the reflect-config.json with the information provided in the PR it is fixed.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Copy link

sonarcloud bot commented Aug 23, 2024

@zoewangg zoewangg added this pull request to the merge queue Aug 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2024
@zoewangg zoewangg added this pull request to the merge queue Aug 23, 2024
Merged via the queue into aws:master with commit 955029a Aug 23, 2024
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVM native image fails because of software.amazon.awssdk.crt.s3.S3Client
2 participants