Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflect-config.json to s3-transfer-manager #5184

Merged
merged 3 commits into from
May 6, 2024

Conversation

klopfdreh
Copy link
Contributor

Motivation and Context

Fixes #5127

Modifications

Added reflect-config.json for ApplyUserAgentInterceptor for s3-transfer-manager module like it is present for ApplyUserAgentInterceptor in dynamodb-enhanced

Testing

I added a reflect-config.json in my project with the same content like in this PR and performed a native-build with -H:ReflectionConfigurationResources=META-INF/native-image/reflect-config.json.

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@klopfdreh klopfdreh requested a review from a team as a code owner May 6, 2024 15:10
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a changelog entry? You can just run the scripts/new-change script and follow the instructions.

@klopfdreh
Copy link
Contributor Author

klopfdreh commented May 6, 2024

Hey @zoewangg -

  1. I installed Python 3
  2. I changed the first line of new-change to #!/user/bin/env python3
  3. Then I used the following command line: ./new-change --type bugfix --category s3-transfer-manager --contributor klopfdreh --description Added reflect-config.json for ApplyUserAgentInterceptor in s3-transfer-manager for native builds

Sadly I got this error:

/...../aws-sdk-java-v2/scripts/./new-change:136: SyntaxWarning: invalid escape sequence '\['
  new_description = re.sub('(?<!\[)#\d+', linkify, description)

@klopfdreh klopfdreh force-pushed the fix/natives3transfermanager branch from a222b2e to 2d58209 Compare May 6, 2024 20:05
@zoewangg
Copy link
Contributor

zoewangg commented May 6, 2024

@klopfdreh could you try running ./new-change directly following the prompt?

@klopfdreh
Copy link
Contributor Author

Because I didn't use any markdown / links in my comment I commented out the linkify function. I added the newly generated json to the change and force pushed it, so that it is only one commit.

@klopfdreh
Copy link
Contributor Author

@klopfdreh could you try running ./new-change directly following the prompt?

I did, but the first line is python2 #!/usr/bin/env python which is outdated and should not be used any longer.

@klopfdreh klopfdreh force-pushed the fix/natives3transfermanager branch from 2d58209 to 015a3e0 Compare May 6, 2024 20:11
@klopfdreh
Copy link
Contributor Author

I removed the duplicated json files in .changes/next-release - I hope it is ok now. 😀

@klopfdreh klopfdreh requested a review from zoewangg May 6, 2024 20:13
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Triggering builds

@zoewangg zoewangg enabled auto-merge (squash) May 6, 2024 20:16
@zoewangg zoewangg disabled auto-merge May 6, 2024 20:16
@zoewangg zoewangg enabled auto-merge (squash) May 6, 2024 20:16
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zoewangg zoewangg merged commit 5038736 into aws:master May 6, 2024
9 of 17 checks passed
@zoewangg
Copy link
Contributor

zoewangg commented May 6, 2024

@all-contributors please add @klopfdreh for code

Copy link
Contributor

@zoewangg

I've put up a pull request to add @klopfdreh! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants