Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to SDK Logging and debug Facilities SDK middleware, API clients, and Config loading #594

Closed
skmcgrail opened this issue Jun 17, 2020 · 3 comments
Labels
feature-request A feature should be added or improved. needs-design

Comments

@skmcgrail
Copy link
Member

The Smithy based design changes to the SDK and the corresponding middleware design has highlighted the need to review our current approach to logging and log levels. Ideally each middleware should be able to produce sufficient logging at various levels of verbosity where necessary, and customers should be able to preferably target middleware by their identifiers to enable/disable and modify the verbosity of the logged statements. Most important is that we must not make assumptions about the underlying logging implementation provided, and allow users to plug into a minimal interface to satisfy with their own implementation or another community library.

@jasdel
Copy link
Contributor

jasdel commented Oct 21, 2020

This issue should also ensure logging is captured by the SDK's LoadDefaultClient for credentials provider.

#355

@jasdel jasdel changed the title Improvements to SDK Logging Facilities for Smithy-based Clients Improvements to SDK Logging and debug Facilities for Smithy-based Clients Oct 21, 2020
@jasdel jasdel changed the title Improvements to SDK Logging and debug Facilities for Smithy-based Clients Improvements to SDK Logging and debug Facilities SDK middleware, API clients, and Config loading Oct 21, 2020
@jasdel jasdel mentioned this issue Oct 21, 2020
3 tasks
@jasdel
Copy link
Contributor

jasdel commented Nov 12, 2020

Thius issue was resolved with, #872

@jasdel jasdel closed this as completed Nov 12, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-design
Projects
None yet
Development

No branches or pull requests

2 participants