Invalid comparison #878
Merged
Invalid comparison #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there :) While analyzing the project I found this small issue. The typeof is compared to undefined. This comparison is invalid because typeof always returns strings.
jessieweiyi
approved these changes
May 8, 2023
|
@jessieweiyi tyvm :) |
jessieweiyi
added a commit
that referenced
this pull request
May 11, 2023
…t is running in a browser (#878)
|
🎉 This PR is included in version aws-northstar-v1.3.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @cesarkohl Thank you for your contribution to NorthStar. Please note that the code under |
|
Great, thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there :) While analyzing the project I found this small issue.
The typeof is compared to undefined. This comparison is invalid because typeof always returns strings.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.