Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTH v2] Should place CRD (without templating) in crds directory for Helm 3 #710

Closed
cjerad opened this issue Oct 19, 2022 · 1 comment
Closed
Assignees

Comments

@cjerad
Copy link
Contributor

cjerad commented Oct 19, 2022

Describe the bug

Thanks @stevehipwell for pointing this out. See previous discussion here

TL;DR Helm 3 wants CRDs in a crds/ directory[1], and discourages templating in CRDs [2].

@cjerad cjerad self-assigned this Oct 19, 2022
@cjerad cjerad mentioned this issue Oct 19, 2022
@stevehipwell
Copy link
Contributor

@cjerad if you wanted to provide custom defaults for terminators you could either add an additional TerminatorDefaults CRD or provide a webhook to mutate terminators as part of the creation process. I'm not sure either is required but the additional CRD would have a significantly lower operational burden than the webhook.

@snay2 snay2 closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants