Skip to content

Commit 24910ad

Browse files
Merge pull request #373 from Pavani-Panakanti/release-1.2-merge
Merge main into release-1.2
2 parents 41d4087 + e13e023 commit 24910ad

File tree

3 files changed

+15
-24
lines changed

3 files changed

+15
-24
lines changed

controllers/policyendpoints_controller.go

+14-12
Original file line numberDiff line numberDiff line change
@@ -224,14 +224,16 @@ func (r *PolicyEndpointsReconciler) cleanUpPolicyEndpoint(ctx context.Context, r
224224
func (r *PolicyEndpointsReconciler) IsProgFdShared(targetPodName string,
225225
targetPodNamespace string) (bool, error) {
226226
targetpodNamespacedName := utils.GetPodNamespacedName(targetPodName, targetPodNamespace)
227-
foundShared := false
228227
// check ingress caches
229228
if targetProgFD, ok := r.ebpfClient.GetIngressPodToProgMap().Load(targetpodNamespacedName); ok {
230229
if currentList, ok := r.ebpfClient.GetIngressProgToPodsMap().Load(targetProgFD); ok {
231230
podsList, ok := currentList.(map[string]struct{})
232-
if ok && len(podsList) > 1 {
233-
foundShared = true
234-
r.log.Info("isProgFdShared", "Found shared ingress progFD for target: ", targetPodName, "progFD: ", targetProgFD)
231+
if ok {
232+
if len(podsList) > 1 {
233+
r.log.Info("isProgFdShared", "Found shared ingress progFD for target: ", targetPodName, "progFD: ", targetProgFD)
234+
return true, nil
235+
}
236+
return false, nil // Not shared (only one pod)
235237
}
236238
}
237239
}
@@ -240,19 +242,19 @@ func (r *PolicyEndpointsReconciler) IsProgFdShared(targetPodName string,
240242
if targetProgFD, ok := r.ebpfClient.GetEgressPodToProgMap().Load(targetpodNamespacedName); ok {
241243
if currentList, ok := r.ebpfClient.GetEgressProgToPodsMap().Load(targetProgFD); ok {
242244
podsList, ok := currentList.(map[string]struct{})
243-
if ok && len(podsList) > 1 {
244-
foundShared = true
245-
r.log.Info("IsProgFdShared", "Found shared egress progFD for target:", targetPodName, "progFD:", targetProgFD)
245+
if ok {
246+
if len(podsList) > 1 {
247+
r.log.Info("IsProgFdShared", "Found shared egress progFD for target:", targetPodName, "progFD:", targetProgFD)
248+
return true, nil
249+
}
250+
return false, nil // Not shared (only one pod)
246251
}
247252
}
248253
}
249254

250255
// If not found in both maps, return an error
251-
if !foundShared {
252-
r.log.Info("IsProgFdShared", "Pod not found in either IngressPodToProgMap or EgressPodToProgMap:", targetpodNamespacedName)
253-
return false, fmt.Errorf("pod not found in either IngressPodToProgMap or EgressPodToProgMap: %s", targetpodNamespacedName)
254-
}
255-
return true, nil
256+
r.log.Info("IsProgFdShared", "Pod not found in either IngressPodToProgMap or EgressPodToProgMap:", targetpodNamespacedName)
257+
return false, fmt.Errorf("pod not found in either IngressPodToProgMap or EgressPodToProgMap: %s", targetpodNamespacedName)
256258
}
257259

258260
func (r *PolicyEndpointsReconciler) updatePolicyEnforcementStatusForPods(ctx context.Context, policyEndpointName string,

pkg/ebpf/bpf_client.go

-11
Original file line numberDiff line numberDiff line change
@@ -372,17 +372,6 @@ func checkAndUpdateBPFBinaries(bpfTCClient tc.BpfTc, bpfBinaries []string, hostB
372372
}
373373
}
374374
}
375-
376-
//Clean up probes
377-
if updateIngressProbe || updateEgressProbe {
378-
err := bpfTCClient.CleanupQdiscs(updateIngressProbe, updateEgressProbe)
379-
if err != nil {
380-
log.Error(err, "Probe cleanup failed")
381-
sdkAPIErr.WithLabelValues("CleanupQdiscs").Inc()
382-
return updateIngressProbe, updateEgressProbe, updateEventsProbe, err
383-
}
384-
}
385-
386375
return updateIngressProbe, updateEgressProbe, updateEventsProbe, nil
387376
}
388377

scripts/lib/cluster.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ function load_default_values(){
1717

1818
# If Kubernetes version is not passed then use the latest available version
1919
if [[ -z $K8S_VERSION ]]; then
20-
K8S_VERSION=$(eksctl version -o json | jq -r '.EKSServerSupportedVersions | sort | reverse | .[0]')
20+
K8S_VERSION=$(eksctl utils describe-cluster-versions | jq -r '.clusterVersions[0].ClusterVersion')
2121
fi
2222

2323
}

0 commit comments

Comments
 (0)