Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert master key provider discovery to use setuptools entry points #30

Closed
mattsb42-aws opened this issue Oct 9, 2017 · 2 comments
Closed

Comments

@mattsb42-aws
Copy link
Member

Rather than passing in a callable path for custom MKPs and using NOP post processing, I think what would be better is to implement a discoverable plugin structure that will guide implementers to define an entry point function that returns a MKP callable and optional post-processing callable.

https://packaging.python.org/guides/creating-and-discovering-plugins/
http://setuptools.readthedocs.io/en/latest/setuptools.html#dynamic-discovery-of-services-and-plugins

@mattsb42-aws
Copy link
Member Author

After discussing with the team, this is going to be a launch requirement.

@mattsb42-aws mattsb42-aws changed the title investigate converting to discoverable plugin structure for MKP/post-processing convert master key discovery to use setuptools entry points Oct 15, 2017
@mattsb42-aws mattsb42-aws changed the title convert master key discovery to use setuptools entry points convert master key provider discovery to use setuptools entry points Oct 15, 2017
@mattsb42-aws
Copy link
Member Author

@juneb This is merged and ready for docs now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants