Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add built-in base64 en/de-coding #29

Closed
mattsb42-aws opened this issue Oct 9, 2017 · 3 comments
Closed

add built-in base64 en/de-coding #29

mattsb42-aws opened this issue Oct 9, 2017 · 3 comments

Comments

@mattsb42-aws
Copy link
Member

Because of all the issues around system shell encoding, we need to support base64 en/de-coding of out/in-put natively within the CLI.

Outstanding question: what do we actually want this control interface to look like? Specifically, do we want to allow turning the encoding on/off independently? I think we need to in order to support reading in unencoded data.

@juneb
Copy link
Contributor

juneb commented Oct 9, 2017

Yes, but the default should be encoded with an option should turn off encoding.

@mattsb42-aws
Copy link
Member Author

No. That I vehemently disagree with. Applying encoding like this without being asked to violates our "least surprise" principal. Any time we are doing additional special encoding, it should be very clear that it is being enabled.

@mattsb42-aws
Copy link
Member Author

To update the issue with offline discussion:

Because the only two cases where this encoding is necessary are: 1) piping in PowerShell, and 2) saving results to shell variables, we agreed that it is best to have the encoding off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants