Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user-defined output filename suffix #12

Closed
mattsb42-aws opened this issue Sep 29, 2017 · 4 comments
Closed

allow user-defined output filename suffix #12

mattsb42-aws opened this issue Sep 29, 2017 · 4 comments

Comments

@mattsb42-aws
Copy link
Member

Default behavior when target is a directory is that the source filename will be replicated in the target directory, with the addition of a .encrypted suffix if encrypting and a .decrypted suffix if decrypting.

Add the ability for the user to specify a custom suffix to use instead.

@mattsb42-aws
Copy link
Member Author

@mattsb42-aws
Copy link
Member Author

Providing an empty string fails.

@juneb
Copy link
Contributor

juneb commented Oct 6, 2017

In cmd.exe, the --suffix parameter with no value fails, but specifying an empty string appends an empty string suffix. We should make this work.

Also, if you specify a value in quotation marks, even single quotes, the file name includes the quotation marks. That's not an expected result.

(py) c:\ps-test>aws-crypto --encrypt --master-keys key=%cmkARN% ^
More?                     --encryption-context Dept=IT --suffix '' ^
More?                     --input .\TestDir --recursive --output .\TestEnc

(py) c:\ps-test>dir .\testenc
 Volume in drive C is OSDisk
 Volume Serial Number is DA92-2FB6

 Directory of c:\ps-test\testenc

10/06/2017  03:34 PM    <DIR>          .
10/06/2017  03:34 PM    <DIR>          ..
10/06/2017  03:34 PM             2,723 cool-new-thing.py''
10/06/2017  03:34 PM               630 Employees.csv''
10/06/2017  03:34 PM               595 Hello.txt''
               3 File(s)          3,948 bytes
               2 Dir(s)  163,718,578,176 bytes free

@mattsb42-aws
Copy link
Member Author

#33 created to track the empty suffix feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants