From 48ae7a9e75fbd92390cf16bcc097288a677122c1 Mon Sep 17 00:00:00 2001 From: Frank <88225527+frankpengau@users.noreply.github.com> Date: Fri, 12 Jan 2024 14:19:03 +1100 Subject: [PATCH 1/4] Moved aws-sdk from devDependencies to dependencies --- packages/@aws-cdk/cloudformation-diff/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/cloudformation-diff/package.json b/packages/@aws-cdk/cloudformation-diff/package.json index 30695252db551..d0e75b3433952 100644 --- a/packages/@aws-cdk/cloudformation-diff/package.json +++ b/packages/@aws-cdk/cloudformation-diff/package.json @@ -25,6 +25,7 @@ "dependencies": { "@aws-cdk/aws-service-spec": "^0.0.41", "@aws-cdk/service-spec-types": "^0.0.41", + "aws-sdk": "2.1532.0", "chalk": "^4", "diff": "^5.1.0", "fast-deep-equal": "^3.1.3", @@ -38,7 +39,6 @@ "@types/string-width": "^4.0.1", "fast-check": "^3.15.0", "jest": "^29.7.0", - "aws-sdk": "2.1532.0", "ts-jest": "^29.1.1" }, "repository": { From 0e30edc43b136091ff92e3363c91c3d633ec91eb Mon Sep 17 00:00:00 2001 From: Frank <88225527+frankpengau@users.noreply.github.com> Date: Fri, 12 Jan 2024 14:38:30 +1100 Subject: [PATCH 2/4] Update package.json latest version of aws-sdk --- packages/@aws-cdk/cloudformation-diff/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/cloudformation-diff/package.json b/packages/@aws-cdk/cloudformation-diff/package.json index d0e75b3433952..2b0f53b29aa60 100644 --- a/packages/@aws-cdk/cloudformation-diff/package.json +++ b/packages/@aws-cdk/cloudformation-diff/package.json @@ -25,7 +25,7 @@ "dependencies": { "@aws-cdk/aws-service-spec": "^0.0.41", "@aws-cdk/service-spec-types": "^0.0.41", - "aws-sdk": "2.1532.0", + "aws-sdk": "2.1534.0", "chalk": "^4", "diff": "^5.1.0", "fast-deep-equal": "^3.1.3", From eba9c7fe9ef42e6bfc38244018b1d496a5b27200 Mon Sep 17 00:00:00 2001 From: Frank Peng <88225527+frankpengau@users.noreply.github.com> Date: Sat, 13 Jan 2024 13:24:57 +1100 Subject: [PATCH 3/4] change to import type for cfn from aws-sdk --- packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts b/packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts index 055bc3be8248b..433eda0b5a10d 100644 --- a/packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts +++ b/packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts @@ -1,7 +1,6 @@ // The SDK is only used to reference `DescribeChangeSetOutput`, so the SDK is added as a devDependency. // The SDK should not make network calls here -// eslint-disable-next-line import/no-extraneous-dependencies -import { CloudFormation } from 'aws-sdk'; +import type { CloudFormation } from 'aws-sdk'; import * as impl from './diff'; import * as types from './diff/types'; import { deepEqual, diffKeyedEntities, unionOf } from './diff/util'; From 311960f6535eab5ab574ca57aa1cccc7f74a1bc4 Mon Sep 17 00:00:00 2001 From: Frank <88225527+frankpengau@users.noreply.github.com> Date: Sat, 13 Jan 2024 13:27:45 +1100 Subject: [PATCH 4/4] Update package.json --- packages/@aws-cdk/cloudformation-diff/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/@aws-cdk/cloudformation-diff/package.json b/packages/@aws-cdk/cloudformation-diff/package.json index ec4260d93b882..561e9ed147daf 100644 --- a/packages/@aws-cdk/cloudformation-diff/package.json +++ b/packages/@aws-cdk/cloudformation-diff/package.json @@ -38,6 +38,7 @@ "@types/string-width": "^4.0.1", "fast-check": "^3.15.0", "jest": "^29.7.0", + "aws-sdk": "2.1532.0", "ts-jest": "^29.1.1" }, "repository": {