-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Regex at doesn't allow a trailing +, it only allows the a-zA-Z1-0 etc portion. #862
Comments
I believe we fixed this already? |
if (!/^[a-zA-Z0-9._-]+$/.test(part)) { doesn't seem like it would work, the only + in there is the repeat for the test pattern. and it doesn't work on my 0.10.0 version I have on my machine. However if I add either + to the [] section or (haven't tested) [+]? before $ it works. |
My example stack is:
If the code is:
Then I get:
If I change resource.ts to be:
Then it works fine. |
Yes, this issue got fixed in #769. It's not part of the 0.10.0 release, but will be part of the next release. |
https://github.com/awslabs/aws-cdk/blob/eb4bacfff68a2f2549572c5714057af01c12b7aa/packages/%40aws-cdk/aws-apigateway/lib/resource.ts#L149
This means you can't legally create {proxy+}, which is pretty important in api gateway.
The text was updated successfully, but these errors were encountered: