Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): missing permissions to add and remove tags for clusters #7302

Merged
merged 3 commits into from
Apr 10, 2020
Merged

fix(eks): missing permissions to add and remove tags for clusters #7302

merged 3 commits into from
Apr 10, 2020

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Apr 10, 2020 •
edited
Loading

Commit Message

fix(eks): missing permissions to add and remove tags when creating EKS cluster resource (#7302)

Added missing permissions for eks:TagResource and eks:UntagResource.
Updated unit and integ test expectations to include the added permissions.

Closes #7163

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks
fix(eks): missing permissions to add and remove tags when creating EK…
d150826 
…S cluster resource

Added missing permissions for `eks:TagResource` and `eks:UntagResource`.
Updated unit and integ test expectations to include the added permissions.

Closes #7163
@shivlaks shivlaks added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 10, 2020
@shivlaks shivlaks requested review from eladb and a team April 10, 2020 18:15
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 10, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d150826
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(eks): missing permissions to add and remove tags when creating EKS cluster resource fix(eks): missing permissions to add and remove tags for clusters Apr 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a5fa1de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b14172d into master Apr 10, 2020
@mergify mergify bot deleted the shivlaks/eks-cluster-missing-perms branch April 10, 2020 20:20
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f03d329
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-eks] missing IAM permissions when creating EKS cluster resource
3 participants
@shivlaks @aws-cdk-automation @eladb