Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amplify): source code providers #6921

Merged
merged 6 commits into from
Mar 30, 2020
Merged

feat(amplify): source code providers #6921

merged 6 commits into from
Mar 30, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 21, 2020 •
edited
Loading

Commit Message

feat(amplify): source code providers

Add source code providers classes for GitHub and CodeCommit that implement
a new ISourceCodeProvider interface.

Fixes #6818

BREAKING CHANGE: use the sourceCodeProvider prop to connect your app to a source
code provider. The props repository, accessToken and oauthToken do not exist
anymore in AppProps.

End of Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
feat(amplify): source code providers
2ee94f0 
Add source code providers classes for GitHub and CodeCommit that implement
a new `ISourceCodeProvider` interface.

BREAKING CHANGE: use the `sourceCodeProvider` prop to connect your app to a source
code provider. The props `repository`, `accessToken` and `oauthToken` do not exist
anymore in `AppProps`.
@jogold
Copy link
Contributor Author

jogold commented Mar 21, 2020

@MrArnoldPalmer

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2ee94f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cb48940
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 618739b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@MrArnoldPalmer
Copy link
Contributor

@skinny85 Would like you check out the additions to codecommit here.

@skinny85 skinny85 added the pr/do-not-merge This PR should not be merged at this time. label Mar 26, 2020
skinny85
skinny85 previously approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skinny85 Would like you check out the additions to codecommit here.

No objections from me, they look great!

packages/@aws-cdk/aws-codecommit/lib/repository.ts Outdated Show resolved Hide resolved
MrArnoldPalmer
MrArnoldPalmer previously approved these changes Mar 26, 2020
View reviewed changes
@mergify mergify bot dismissed stale reviews from skinny85 and MrArnoldPalmer March 26, 2020 18:23

Pull request has been modified.

@jogold jogold requested a review from MrArnoldPalmer March 26, 2020 18:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3589b98
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 424fcf4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor Author

jogold commented Mar 27, 2020

Hey @MrArnoldPalmer, any reason why you're leaving this as pr/do-not-merge?

@MrArnoldPalmer MrArnoldPalmer removed the pr/do-not-merge This PR should not be merged at this time. label Mar 30, 2020
@MrArnoldPalmer
Copy link
Contributor

Hey @MrArnoldPalmer, any reason why you're leaving this as pr/do-not-merge?

Nope, sorry just missed it.

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8743160
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3dc3d75 into aws:master Mar 30, 2020
@jogold jogold deleted the amplify-providers branch April 27, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

@skinny85 skinny85 skinny85 left review comments

Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Amplify module with CodeCommit Repository
4 participants
@jogold @aws-cdk-automation @MrArnoldPalmer @skinny85