Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-test-integ cannot run in the pipeline #6328

Closed
eladb opened this issue Feb 18, 2020 · 7 comments
Closed

npm-test-integ cannot run in the pipeline #6328

eladb opened this issue Feb 18, 2020 · 7 comments
Assignees
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 package/tools Related to AWS CDK Tools or CLI testing Related to tests needed to be modified or added.

Comments

@eladb
Copy link
Contributor

eladb commented Feb 18, 2020

The new CLI test npm-test-integ, which was introduced as part of #5856 cannot be executed as part of our CI pipeline because it assumes we have a development environment (cdk-integ for example).

We removed this test in #6327 to unblock our builds, but we need to figure what to do about it.

Error Log

============================================================================================
--
972 | test-npm-integ.sh
973 | ============================================================================================
974 |  
975 | > aws-cdk@1.24.0 integ /codebuild/output/src676395972/src/package
976 | > jest --testMatch '**/?(*.)+(integ-test).ts'
977 |  
978 | sh: jest: command not found
979 | npm ERR! code ELIFECYCLE
980 | npm ERR! syscall spawn
981 | npm ERR! file sh
982 | npm ERR! errno ENOENT
983 | npm ERR! aws-cdk@1.24.0 integ: `jest --testMatch '**/?(*.)+(integ-test).ts'`
984 | npm ERR! spawn ENOENT
985 | npm ERR!
986 | npm ERR! Failed at the aws-cdk@1.24.0 integ script.
987 | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
988 | npm WARN Local package.json exists, but node_modules missing, did you mean to install?
989 |  
990 | npm ERR! A complete log of this run can be found in:
991 | npm ERR!     /root/.npm/_logs/2020-02-18T05_01_24_571Z-debug.log

This is 🐛 Bug Report

@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 18, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 18, 2020

Thinking on this some more... an "npm install" of jest and @aws-cdk/core etc should be enough. It will be read proxied through verdaccio. The .ts will have been compiled to .js as part fo the regular package build.

I'm leaning towards a separate package.json for integ test dependencies, but we'll have to hide that from lerna. Or shouldn't we?

@eladb
Copy link
Contributor Author

eladb commented Feb 18, 2020

What about cdk-integ, which is not published publicly?

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 18, 2020

What about it?

@eladb
Copy link
Contributor Author

eladb commented Feb 18, 2020

Doesn't the integration test use it?

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 19, 2020

No. We have 2 completely different things we both call "integration tests".

We should rename one of them. "template tests" or something.

@SomayaB SomayaB added package/tools Related to AWS CDK Tools or CLI testing Related to tests needed to be modified or added. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2020
@skinny85 skinny85 added effort/medium Medium work item – several days of effort p1 labels Mar 19, 2020
@skinny85
Copy link
Contributor

skinny85 commented Dec 7, 2020

This one was fixed in #7041.

@skinny85 skinny85 closed this as completed Dec 7, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 package/tools Related to AWS CDK Tools or CLI testing Related to tests needed to be modified or added.
Projects
None yet
Development

No branches or pull requests

4 participants