Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route53): incorrect domain name produced when using HTTPS in ApplicationLoadBalancedFargateService #5802

Merged
merged 9 commits into from
Jan 20, 2020
Merged

fix(route53): incorrect domain name produced when using HTTPS in ApplicationLoadBalancedFargateService #5802

merged 9 commits into from
Jan 20, 2020

Conversation

Don-CA
Copy link
Contributor

@Don-CA Don-CA commented Jan 15, 2020

The trailing dot in hostedZone.zoneName should be ignored to match with the providedName.

Added missing tests in aws-route53 and integration tests in aws-ecs-patterns

Fixes: #5801

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(aws-route53): ignore zone name trailing dot in determineFullyQualifiedDomainName fix(route53): ignore zone name trailing dot in determineFullyQualifiedDomainName Jan 15, 2020
eladb
eladb reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title should describe the bug, not the fix

@Don-CA Don-CA changed the title fix(route53): ignore zone name trailing dot in determineFullyQualifiedDomainName fix(route53): incorrect domain name produced when using HTTPS in ApplicationLoadBalancedFargateService Jan 15, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB assigned NetaNir and shivlaks and unassigned NetaNir Jan 15, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Don-CA Don-CA requested a review from eladb January 15, 2020 23:15
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks previously requested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the documentation need to be updated here as well?

@Don-CA
Copy link
Contributor Author

Don-CA commented Jan 17, 2020 •
edited
Loading

does the documentation need to be updated here as well?

No, it now behaves in line with the documentation, although looking at it, I realised I needed a fourth test for complete matches

@mergify mergify bot dismissed shivlaks’s stale review January 17, 2020 00:10

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Don-CA Don-CA requested a review from shivlaks January 17, 2020 04:44
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 5ba5a5e into aws:master Jan 20, 2020
@Don-CA Don-CA deleted the correct-domain-name-in-https-service branch January 21, 2020 01:46
@netroy
Copy link
Contributor

netroy commented Feb 17, 2020

@Don-CA for the integration tests: Did you use a hosted zone from your account & then replace the id in json with fakeId?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

@eladb eladb Awaiting requested review from eladb

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect domain name produced when using HTTPS in ApplicationLoadBalancedFargateService
6 participants
@Don-CA @aws-cdk-automation @netroy @eladb @shivlaks @NetaNir