fix(iam): policy added to resource for immutable Role #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`addToPolicy()` is supposed to return `true` or `false` indicating whether the policy was added to an identity for the purposes of determining whether it should be added to a resource policy instead. It's an error if a `Grant` can't be added to the identity *and* it can't be added to the resource (because the resource doesn't support resource policies). Immutable roles should return `true` (even though they didn't actually add the statement to any policy), because we assume the user already put the right permissions on the identity, so we pretend the add worked.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Maybe in v2.0 we should return an enum instead of a boolean, so it will be more readable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addToPolicy()is supposed to returntrueorfalseindicatingwhether the policy was added to an identity for the purposes of
determining whether it should be added to a resource policy instead.
It's an error if a
Grantcan't be added to the identity and it can'tbe added to the resource (because the resource doesn't support resource
policies).
Immutable roles should return
true(even though they didn't actuallyadd the statement to any policy), because we assume the user already
put the right permissions on the identity, so we pretend the add worked.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license