Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-codebuild ComputeType missing new options #5401

Closed
DmitryNefedov opened this issue Dec 13, 2019 · 2 comments
Closed

aws-codebuild ComputeType missing new options #5401

DmitryNefedov opened this issue Dec 13, 2019 · 2 comments
Assignees
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild feature-request A feature should be added or improved.

Comments

@DmitryNefedov
Copy link
Contributor

DmitryNefedov commented Dec 13, 2019

❓ General Issue

aws-codebuild is missing new options in ComputeType.
Only half of the available build environment compute types are present.
https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-compute-types.html

Environment

  • CDK CLI Version: 1.18.0
  • Module Version: "@aws-cdk/aws-codebuild": "1.18.0"
  • OS: Windows 10
  • Language: TypeScript

Other information

https://github.com/aws/aws-cdk/blob/v1.18.0/packages/@aws-cdk/aws-codebuild/lib/project.ts#L998

project.d.ts
/**
 * Build machine compute type.
 */
export declare enum ComputeType {
    SMALL = "BUILD_GENERAL1_SMALL",
    MEDIUM = "BUILD_GENERAL1_MEDIUM",
    LARGE = "BUILD_GENERAL1_LARGE"
}
@DmitryNefedov DmitryNefedov added the needs-triage This issue or PR still needs to be triaged. label Dec 13, 2019
@skinny85
Copy link
Contributor

@DmitryNefedov any chance you'd consider opening us a Pull Request with the changes? It should be as simple as adding the new values into this enum 🙂.

Thanks,
Adam

@SomayaB SomayaB added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Dec 13, 2019
@SomayaB SomayaB added feature-request A feature should be added or improved. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 13, 2019
@DmitryNefedov
Copy link
Contributor Author

@skinny85 sure thing.
Here you go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants