Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigateway): publish api endpoint through an export name #3662 #4849

Merged
merged 8 commits into from
Nov 8, 2019
Merged

feat(apigateway): publish api endpoint through an export name #3662 #4849

merged 8 commits into from
Nov 8, 2019

Conversation

whimzyLive
Copy link
Contributor

@whimzyLive whimzyLive commented Nov 5, 2019 •
edited
Loading

RestApiProps accepts optional exportName property, if given, CDK will use that exportName when creating CfnOutput for API.
fixes #3662

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously requested changes Nov 5, 2019
View reviewed changes
packages/@aws-cdk/aws-apigateway/lib/restapi.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/restapi.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/restapi.ts Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Rushi Patel added 2 commits November 6, 2019 20:05
chore(apigateway): refactor endpointExportName resolution logic
9e4b8db
Merge branch 'allow-customising-name-of-cfnoutput-containing-api-endp…
5848ce3 
…oint' of github.com:wimzyLive/aws-cdk into allow-customising-name-of-cfnoutput-containing-api-endpoint
@mergify mergify bot dismissed eladb’s stale review November 6, 2019 09:35

Pull request has been modified.

@whimzyLive whimzyLive requested a review from eladb November 6, 2019 09:39
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title feat(apigateway): allow customizing the name of the CfnOutput #3662 feat(apigateway): publish api endpoint through an export name #3662 Nov 7, 2019
eladb
eladb reviewed Nov 7, 2019
View reviewed changes
packages/@aws-cdk/aws-apigateway/lib/restapi.ts
Comment on lines -395 to +402
new CfnOutput(this, 'Endpoint', { value: this.urlForPath() });
new CfnOutput(this, 'Endpoint', { exportName: props.endpointExportName, value: this.urlForPath() });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to be a bit simpler. LMK if it looks ok

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at assigned eladb and unassigned nija-at Nov 7, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 652a8f5 into aws:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@nija-at nija-at Awaiting requested review from nija-at

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[apigateway] Allow customizing the name of the CfnOutput containing the API endpoint
4 participants
@whimzyLive @aws-cdk-automation @eladb @nija-at