Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk init lib should come with unit tests #3945

Closed
1 of 2 tasks
rhboyd opened this issue Sep 4, 2019 · 3 comments · Fixed by #3948
Closed
1 of 2 tasks

cdk init lib should come with unit tests #3945

rhboyd opened this issue Sep 4, 2019 · 3 comments · Fixed by #3948
Assignees
@rix0rrr @eladb
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. management/devenv Related to CDK development/build environment

Comments

@rhboyd
Copy link
Contributor

rhboyd commented Sep 4, 2019

🚀 Feature Request

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

when running cdk init --language typescript lib the generated code should include the devDependencies on nodeunit and cdk-assert as well as sample unit tests for the SQS Queue and SNS Topic it creates by default.

Proposed Solution

Should be a pretty straight-forward change to the TS Template.

Environment

  • Language: TypeScript

Other information
@rhboyd rhboyd added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2019
@SomayaB SomayaB added @aws-cdk/core Related to core CDK functionality @aws-cdk/assert Related to the @aws-cdk/assert package @aws-cdk/aws-sqs Related to Amazon Simple Queue Service @aws-cdk/aws-sns Related to Amazon Simple Notification Service labels Sep 4, 2019
@NGL321 NGL321 added management/devenv Related to CDK development/build environment and removed @aws-cdk/aws-sns Related to Amazon Simple Notification Service @aws-cdk/aws-sqs Related to Amazon Simple Queue Service needs-triage This issue or PR still needs to be triaged. @aws-cdk/assert Related to the @aws-cdk/assert package labels Sep 4, 2019
@NGL321
Copy link
Contributor

NGL321 commented Sep 4, 2019

Duplicate of #1217, but since that is a number of versions behind and this is more explanatory, I will keep this issue!

@NGL321 NGL321 mentioned this issue Sep 4, 2019
Closed
@rhboyd
Copy link
Contributor Author

rhboyd commented Sep 4, 2019

Ohhh, I didn’t know nodeunit was deprecated. I’m not up on the TS ecosystem. Would jest be the in vogue alternative?

@rhboyd
Copy link
Contributor Author

rhboyd commented Sep 5, 2019

#3948

@rhboyd rhboyd mentioned this issue Sep 5, 2019
Merged
@mergify mergify bot closed this as completed in #3948 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

@eladb eladb

Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. management/devenv Related to CDK development/build environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): added jest tests to typescript templates
5 participants
@rix0rrr @eladb @NGL321 @SomayaB @rhboyd