Lambda: invalid inline code examples

[nmussy]

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

• I'm submitting a ...

  • 🪲 bug report
  • 🚀 feature request
  • 📚 construct library gap
  • ☎️ security issue or vulnerability => Please see policy
  • ❓ support request => Please see note at the top of this template.

• What is the current behavior?
  If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

The Lambda DLQ example uses inline code with the NODEJS_10_X runtime, which doesn't support inline code:

aws-cdk/packages/@aws-cdk/aws-lambda/lib/runtime.ts

Line 36 in 9d19aef

public static readonly NODEJS_10_X = new Runtime('nodejs10.x', RuntimeFamily.NODEJS, { supportsInlineCode: false });

Trying to run it throws the following error, as expected:

Inline source not allowed for nodejs10.x

• What is the expected behavior (or behavior of feature suggested)?

Another runtime should be used in the examples

• What is the motivation / use case for changing the behavior or adding this feature?

Fix the README example

• Please tell us about your environment:

  • CDK CLI Version: 1.3.0
  • Module Version: 1.3.0
  • OS: all
  • Language: all

• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

Inline support might have been added for NODEJS_10_X since #2544 from what I can see on the UI Console:

EDIT: I tried forcing a NODEJS_10_X inline deployment, but I get a CloudFormation error:

 ZipFile canonly be used when Runtime is set to either of nodejs, nodejs4.3, nodejs6.10, nodejs8.10, python2.7, python3.6, python3.7.

There's an issue open for it on the Roadmap: aws-cloudformation-coverage-roadmap#80