fix(cli): conversion of "tags" filter for EC2 DescribeVpcs call #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in the `Filters` parameter of the `DescribeVpcs` call, the tags
need to be encoded as `{ Name: "tag:<name>", Values: ["<value>"] }`, but
the `tag:` prefix was not added by the preparation code.
Fixes #3372
|
Any chance we can add an integ test for this? Some form of test? |
eladb
approved these changes
Jul 23, 2019
|
Yeah I can build on the same test strategy that #3171 uses once it's merged... Just waiting for that to land :) |
eladb
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in the
Filtersparameter of theDescribeVpcscall, the tagsneed to be encoded as
{ Name: "tag:<name>", Values: ["<value>"] }, butthe
tag:prefix was not added by the preparation code.Fixes #3372
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license