Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-lambda-nodejs): Support Bun's new text-based lockfile (bun.lock) for NodejsFunction bundling #33464

Closed
1 task
garysassano opened this issue Feb 15, 2025 · 2 comments
Labels
@aws-cdk/aws-lambda-nodejs bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@garysassano
Copy link
Contributor

garysassano commented Feb 15, 2025

Describe the bug

As per title, NodejsFunction currently doesn't support Bun's new text-based lockfile introduced in v1.2.0, which is now the default.

Error: Cannot find a package lock file (`pnpm-lock.yaml`, `yarn.lock`, `bun.lockb` or `package-lock.json`). Please specify it with `depsLockFilePath`.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

See above.

Current Behavior

See above.

Reproduction Steps

See above.

Current Workaround

const testFunction = new NodejsFunction(this, "TestFunction", {
  entry: join(__dirname, "..", "functions/test", "index.ts"),
  depsLockFilePath: join(__dirname, "..", "..", "bun.lock"),
  runtime: Runtime.NODEJS_22_X,
  architecture: Architecture.ARM_64,
});

Additional Information/Context

This issue is related to #31753

CDK CLI Version

2.178.2

Framework Version

No response

Node.js Version

22.13.0

OS

Ubuntu 24.04.1

Language

TypeScript

Language Version

No response

Other information

No response

@garysassano garysassano added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2025
@pahud
Copy link
Contributor

pahud commented Feb 15, 2025

Thank you. Related to #33270 so I'm closing this in favor of #33270

@pahud pahud closed this as completed Feb 15, 2025
@pahud pahud added p2 effort/medium Medium work item – several days of effort labels Feb 15, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@pahud pahud removed the needs-triage This issue or PR still needs to be triaged. label Feb 15, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-lambda-nodejs bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants