Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff and security diff during deploy #33435

Open
mrgrain opened this issue Feb 13, 2025 · 0 comments
Open

Diff and security diff during deploy #33435

mrgrain opened this issue Feb 13, 2025 · 0 comments
Assignees
@kaizencc
Labels
@aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Feb 13, 2025 •
edited
Loading

We currently do not send a message for the diff on deploy, only if we need to confirm approval.

We should send

  • a info message with the formatted security diff
  • a request response with the full diff to confirm
  • require approval should move into the CliIoHost
@mrgrain mrgrain self-assigned this Feb 13, 2025
@mrgrain mrgrain changed the title Re look at security diff Diff and security diff during deploy Feb 13, 2025
@mrgrain mrgrain removed their assignment Feb 13, 2025
@pahud pahud added feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort p1 @aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI labels Feb 14, 2025
@kaizencc kaizencc self-assigned this Feb 25, 2025
@github-actions github-actions bot mentioned this issue Mar 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaizencc kaizencc

Labels
@aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pahud @mrgrain @kaizencc