Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): do not print credentials refreshed by plugins #33398

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 11, 2025

Issue #33394

Closes #33394

Reason for this change

In #32354 we started logging credentials provided by a plugin to stderr. In #32708 we changed the log statement in a way that the credentials would be logged to stdout in CI environments (but still to stderr in all other environments).

Description of changes

Do not log credentials.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

n/a

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner February 11, 2025 18:47
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p0 labels Feb 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2025 18:47
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-codecov The PR linter will not require codecov checks to pass labels Feb 11, 2025
@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Feb 11, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 11, 2025 18:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain
Copy link
Contributor Author

mrgrain commented Feb 11, 2025

Exempted test requirements.

Added pr-linter/cli-integ-tested despite it not being tested. The PR will have to go through the full pipeline anyway to be released and is low risk to break the pipeline before that.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (9449f9c) to head (15d9a5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33398      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files         236      236              
  Lines       14256    14255       -1     
  Branches     2491     2491              
==========================================
- Hits        11537    11536       -1     
  Misses       2434     2434              
  Partials      285      285              
Flag Coverage Δ
suite.unit 80.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <100.00%> (-0.01%) ⬇️
packages/aws-cdk-lib/core 82.20% <ø> (ø)

Copy link
Contributor

mergify bot commented Feb 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 15d9a5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a7d7373 into main Feb 11, 2025
19 of 20 checks passed
Copy link
Contributor

mergify bot commented Feb 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the mrgrain/fix/cli/no-print-credentials branch February 11, 2025 19:54
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p0 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-codecov The PR linter will not require codecov checks to pass pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: AWS CDK CLI Exposes Credentials in Output
4 participants