-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: metadata collection for construct methods #33292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Manual changes to the classes.ts file are not allowed.
❌ Manual changes to the enums.ts file are not allowed.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
This PR added a label to allow exempt but will not take effect until this PR is merged. Will ignore this check.
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (90.47%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #33292 +/- ##
==========================================
+ Coverage 80.80% 80.83% +0.03%
==========================================
Files 236 236
Lines 14235 14253 +18
Branches 2487 2490 +3
==========================================
+ Hits 11503 11522 +19
+ Misses 2448 2446 -2
- Partials 284 285 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tools/@aws-cdk/construct-metadata-updater/lib/metadata-updater.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Changes look good to me, approving and adding the do-not-merge
label for now which can be removed after the test is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GavinZZ for this change. LGTM overall. Just a minor comment for clarification.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Manual changes to the classes.ts file are not allowed.
❌ Manual changes to the enums.ts file are not allowed.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
@Mergifyio requeue |
Going to manually override and merge this PR as this PR will always fail due to manual changes to |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@mergify requeue |
☑️ This pull request is already queued |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
Support construct public method logging. Method name, keys, and property values of Boolean and ENUM types - When you use an L2 construct method, we will collect the method name, property keys, and property values of Boolean and enum types.
Description of changes
Based on the discussion #33198. This change adds
@MetadataMethod
decorator to public construct methods which will allow metadata logging during synthesis intoAWS::CDK::Metadata
resource.Describe any new or updated permissions being added
N/A
Description of how you validated changes
No integ test is possible as integ test requires analytics reporting to be false. Unit tests added.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license