feat(cli): add --untrust option to bootstrap #33091
Conversation
github-actions
bot
added
bug
otaviomacedo
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
| } | ||
|
|
||
| const removeUntrusted = (accounts: string[]) => | ||
| accounts.filter(acc => !params.untrustedAccounts?.map(String).includes(String(acc))); |
There was a problem hiding this comment.
Defensively programming against yargs: despite being typed as string, these values may come as numbers.
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33091/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
otaviomacedo
added
pr-linter/exempt-readme
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33091 +/- ##
==========================================
+ Coverage 81.53% 81.54% +0.01%
==========================================
Files 226 226
Lines 13769 13777 +8
Branches 2414 2414
==========================================
+ Hits 11227 11235 +8
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
otaviomacedo
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Add a new option,
--untrust, to thebootstrapcommand. Passing a list of account IDs as values to this option removes those account IDs from the trust relationships in the bootstrap roles.Closes #22703.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license