Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront-origins): read versioned access level #33038

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

matthiasgubler
Copy link
Contributor

Issue # (if applicable)

Closes #33034

Reason for this change

This allows creating an S3 bucket origin OriginAccessControl for access of versioned objects via CloudFront.

Description of changes

Added a new AccessLevel.READ_VERSIONED, to extend the list of the OAC access levels, which extends the S3 bucket policy to contain s3:GetObjectVersion. I followed the existing patterns for the different AccessLevels, to make the change as small as possible.

This enables versioned S3 bucket origins to allow the CloudFront distribution to access object versions.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Added a new unit-test and a new integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2025 21:59
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jan 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (afa3d1f) to head (3c0b309).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33038   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@matthiasgubler matthiasgubler force-pushed the 33034-add-versioned-access branch from 7aaae57 to ba38355 Compare January 22, 2025 00:33
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 22, 2025 00:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@matthiasgubler matthiasgubler force-pushed the 33034-add-versioned-access branch from ba38355 to 8b6d00d Compare January 22, 2025 00:55
@matthiasgubler matthiasgubler marked this pull request as ready for review January 22, 2025 02:03
This allows creating an S3 bucket origin OriginAccessControl for access of versioned objects

Fixes aws#33034
@matthiasgubler matthiasgubler force-pushed the 33034-add-versioned-access branch from 8b6d00d to 51ce2c9 Compare January 22, 2025 02:08
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 22, 2025
@matthiasgubler
Copy link
Contributor Author

@moelasmar can you help me with this: #33034 (comment)

@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 20, 2025

@matthiasgubler I see the CodeBuild CI is successful. Is your comment related to the Code scanning results / CodeQL? If so, I have proceeded to dismiss the alert as it's used in test snapshot.

GavinZZ
GavinZZ previously approved these changes Feb 20, 2025
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@GavinZZ GavinZZ self-assigned this Feb 20, 2025
Copy link
Contributor

mergify bot commented Feb 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Feb 20, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 20, 2025
@matthiasgubler
Copy link
Contributor Author

@GavinZZ yes, it was the CodeQL in the generated IT code: This does not escape backslash characters in the input.

Thank you for checking and approving it!

Copy link
Contributor

mergify bot commented Feb 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review February 20, 2025 22:04

Pull request has been modified.

GavinZZ
GavinZZ previously approved these changes Feb 20, 2025
Copy link
Contributor

mergify bot commented Feb 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Feb 20, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 20, 2025

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 20, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Copy link
Contributor

mergify bot commented Feb 20, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 20, 2025

@mergify update

Copy link
Contributor

mergify bot commented Feb 20, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/yarn-upgrade.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review February 20, 2025 23:10

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3c0b309
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 315be88 into aws:main Feb 20, 2025
22 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
@matthiasgubler matthiasgubler deleted the 33034-add-versioned-access branch February 21, 2025 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cloudfront-origins): Enable S3 versioned access for OAC
4 participants