feat(lambda): throw ValidationError instead of untyped errors
#33033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
added
pr-linter/exempt-readme
kaizencc
reviewed
Jan 21, 2025
| @@ -78,10 +79,10 @@ export class CodeSigningConfig extends Resource implements ICodeSigningConfig { | |||
| * @param id The construct's name. | |||
| * @param codeSigningConfigArn The ARN of code signing config. | |||
| */ | |||
| public static fromCodeSigningConfigArn( scope: Construct, id: string, codeSigningConfigArn: string): ICodeSigningConfig { | |||
| public static fromCodeSigningConfigArn(scope: Construct, id: string, codeSigningConfigArn: string): ICodeSigningConfig { | |||
There was a problem hiding this comment.
argh! should be a linter rule
kaizencc
reviewed
Jan 21, 2025
Comment on lines
+116
to
+117
| public _bind(scope: Construct, fn: IFunction): InsightsBindConfig { | ||
| const arch = fn.architecture?.name ?? Architecture.X86_64.name; |
There was a problem hiding this comment.
who decided it made sense to continue to use _function 😂
kaizencc
approved these changes
Jan 21, 2025
mrgrain
changed the base branch from
mrgrain/feat/l1/validation-error
to
main
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33033 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 224 224
Lines 13755 13755
Branches 2413 2413
=======================================
Hits 11209 11209
Misses 2273 2273
Partials 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mrgrain
force-pushed
the
mrgrain/feat/lambda/validation-error
branch
from
ce27061 to
c32a5f8
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
aws-lambdafor #32569Description of changes
Updated thrown errors.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests. Exemptions granted as this is basically a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license