-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2-alpha): add Transit Gateway L2 #32956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32956 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 232 232
Lines 14135 14135
Branches 2460 2460
=======================================
Hits 11428 11428
Misses 2427 2427
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left some comments to help me understand.
packages/@aws-cdk/aws-ec2-alpha/lib/transit-gateway-vpc-attachment.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/transit-gateway-route-table.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. Thanks for all the hard work @paulhcsun !!
adding do-not-merge label for final approval from @GavinZZ
packages/@aws-cdk/aws-ec2-alpha/lib/transit-gateway-route-table-association.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/transit-gateway-route-table-association.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/transit-gateway-vpc-attachment.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, just a few nits and questions - great work @paulhcsun ! 👏
packages/@aws-cdk/aws-ec2-alpha/lib/transit-gateway-route-table.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work and patiently addressing the comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
@Mergifyio update |
☑️ Nothing to do
|
@Mergifyio update |
✅ Branch has been successfully updated |
@Mergifyio update |
✅ Branch has been successfully updated |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #17528
Description of changes
Create new Transit Gateway L2 with the following constructs:
TransitGateway
TransitGatewayRouteTable
TransitGatewayRoute
TransitGatewayVpcAttachment
TransitGatewayRouteTableAssociation
TransitGatewayRouteTablePropagation
Important Design Decision
As described in the README, the CDK disables the creation of the default route table by EC2 and instead the CDK will create a "custom" default route table in its place. This is primarily because there is no way to obtain the route table ID of the EC2 created default route table without a custom resource.
The CDK will disable the
defaultRouteTablePropagation
anddefaultRouteTableAssociation
properties on the L1 (when both are disabled, EC2 does not create the default route table), but the properties are still exposed on the CDK TransitGateway interface to allow it to be toggled for the CDK created default route table. The automatic association/propagation is being mimicked by CDK implementation and not relying on the actual EC2 feature.Describe any new or updated permissions being added
n/a
Description of how you validated changes
Unit + Integration tests to verify that the deployed resources behave as expected.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license