Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2-alpha): add Transit Gateway L2 #32956

Merged
merged 28 commits into from
Feb 3, 2025

Conversation

paulhcsun
Copy link
Contributor

@paulhcsun paulhcsun commented Jan 15, 2025

Issue # (if applicable)

Closes #17528

Description of changes

Create new Transit Gateway L2 with the following constructs:

  • TransitGateway
  • TransitGatewayRouteTable
  • TransitGatewayRoute
  • TransitGatewayVpcAttachment
  • TransitGatewayRouteTableAssociation
  • TransitGatewayRouteTablePropagation

Important Design Decision

As described in the README, the CDK disables the creation of the default route table by EC2 and instead the CDK will create a "custom" default route table in its place. This is primarily because there is no way to obtain the route table ID of the EC2 created default route table without a custom resource.

The CDK will disable the defaultRouteTablePropagation and defaultRouteTableAssociation properties on the L1 (when both are disabled, EC2 does not create the default route table), but the properties are still exposed on the CDK TransitGateway interface to allow it to be toggled for the CDK created default route table. The automatic association/propagation is being mimicked by CDK implementation and not relying on the actual EC2 feature.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Unit + Integration tests to verify that the deployed resources behave as expected.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 21:38
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 15, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (9ae1d34) to head (4b63235).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32956   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         232      232           
  Lines       14135    14135           
  Branches     2460     2460           
=======================================
  Hits        11428    11428           
  Misses       2427     2427           
  Partials      280      280           
Flag Coverage Δ
suite.unit 80.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.64% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@paulhcsun paulhcsun changed the title feat(ec2-alpha): Transit Gateway L2 feat(ec2-alpha): add Transit Gateway L2 Jan 22, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 23, 2025 01:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun paulhcsun marked this pull request as ready for review January 23, 2025 23:08
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left some comments to help me understand.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 25, 2025 00:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ self-assigned this Jan 27, 2025
Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. Thanks for all the hard work @paulhcsun !!
adding do-not-merge label for final approval from @GavinZZ

@shikha372 shikha372 added the pr/do-not-merge This PR should not be merged at this time. label Jan 30, 2025
@shikha372 shikha372 self-assigned this Jan 30, 2025
Copy link
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, just a few nits and questions - great work @paulhcsun ! 👏

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work and patiently addressing the comments!

Copy link
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulhcsun
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 31, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@paulhcsun paulhcsun removed the pr/do-not-merge This PR should not be merged at this time. label Jan 31, 2025
@paulhcsun
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 31, 2025

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@paulhcsun
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 31, 2025

update

✅ Branch has been successfully updated

@aaythapa
Copy link
Contributor

aaythapa commented Feb 1, 2025

@Mergifyio update

Copy link
Contributor

mergify bot commented Feb 1, 2025

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e63d92a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun paulhcsun merged commit af44791 into aws:main Feb 3, 2025
11 of 12 checks passed
@paulhcsun paulhcsun deleted the vpcv2-transit-gateway branch February 3, 2025 10:19
Copy link

github-actions bot commented Feb 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-ec2): L2 Transit Gateway
6 participants