Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds: scalability is spelled wrong #32415

Closed
1 task
mbonig opened this issue Dec 7, 2024 · 5 comments · Fixed by #32825
Closed
1 task

rds: scalability is spelled wrong #32415

mbonig opened this issue Dec 7, 2024 · 5 comments · Fixed by #32825
Assignees
@iankhou
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@mbonig
Copy link
Contributor

mbonig commented Dec 7, 2024

Describe the bug

In this recent PR:

https://github.com/aws/aws-cdk/pull/32151/files#diff-49b4a9e1bf0b7db3ab71f4f08580da0cb2191d84605dc82a70c324bd122d5cf7

this introduced a new clusterScailabilityType property which is spelled wrong and will cause confusion

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I expected things to be spelled correctly.

Current Behavior

There is a typo, clusterScailabilityType should be clusterScalabilityType

Reproduction Steps

None, it's a typo

Possible Solution

replace all Scailability with Scalability

Additional Information/Context

No response

CDK CLI Version

Framework Version

No response

Node.js Version

OS

Language

TypeScript

Language Version

No response

Other information

No response
@mbonig mbonig added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2024
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Dec 7, 2024
@pahud
Copy link
Contributor

pahud commented Dec 9, 2024

Err...Yes we should get it fixed.

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 9, 2024
@mazyu36
Copy link
Contributor

mazyu36 commented Dec 10, 2024 •
edited
Loading

@badmintoncryer
FYI.
Sorry, I also missed this during the review​​​​​​​​​​​​​​​​.

@badmintoncryer
Copy link
Contributor

@mazyu36 Thanks! Of all things, I messed up with the argument name... I'm sorry @mbonig 😭

@pahud Is this a breaking change? Or should I add the correct name property and make the old property deprecated?

This was referenced Jan 1, 2025
Open
Open
Open
@kaizencc kaizencc added the good first issue Related to contributions. See CONTRIBUTING.md label Jan 9, 2025
@iankhou iankhou self-assigned this Jan 9, 2025
This was referenced Jan 9, 2025
Closed
Merged
@mergify mergify bot closed this as completed in #32825 Jan 10, 2025
@mergify mergify bot closed this as completed in d39e835 Jan 10, 2025
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iankhou iankhou

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rds): clusterScailabilityType is spelled wrong and should be clusterScalabilityType aws/aws-cdk
6 participants
@pahud @mbonig @mazyu36 @kaizencc @iankhou @badmintoncryer