Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-elasticloadbalancingv2): SslPolicy missing ELBSecurityPolicy-TLS13-1-2-2021-06 #32307

Closed
1 task
lumattr opened this issue Nov 27, 2024 · 3 comments · Fixed by #32379
Closed
1 task

(aws-elasticloadbalancingv2): SslPolicy missing ELBSecurityPolicy-TLS13-1-2-2021-06 #32307

lumattr opened this issue Nov 27, 2024 · 3 comments · Fixed by #32379
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. effort/small Small work item – less than a day of effort p3

Comments

@lumattr
Copy link

lumattr commented Nov 27, 2024

Describe the bug

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/enums.ts#L132-L145

You have TLS13_10, TLS13_11, and TLS13_13, but no TLS13_12.

Its apparently in RECOMMENDED_TLS which seems like a silly idea as that may change causing unexpected changes for consumers if that ever changes.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

If its a list of available policies it should be a consistent list with the policies available.

Current Behavior

Missing the most commonly used policy in the expected place.

Reproduction Steps

N/A

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

15.29.6

Framework Version

No response

Node.js Version

v22.11.0

OS

Ubuntu

Language

TypeScript

Language Version

No response

Other information

No response

@lumattr lumattr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Nov 27, 2024
@ashishdhingra ashishdhingra self-assigned this Nov 27, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2024
@ashishdhingra
Copy link
Contributor

We cannot rename existing SslPolicy.RECOMMENDED_TLS enum value name. Probably, introducing another enum name TLS13_12 with value ELBSecurityPolicy-TLS13-1-2-2021-06 should mitigate this issue.

@lumattr Feel free to contribute PR mentioning reason for change, that could be reviewed by the team. They should reply back in case of any concerns.

Thanks,
Ashish

@ashishdhingra ashishdhingra added p3 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 27, 2024
@ashishdhingra ashishdhingra removed their assignment Nov 27, 2024
@GavinZZ GavinZZ closed this as completed in 7d1dd0d Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

github-actions bot commented Dec 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. effort/small Small work item – less than a day of effort p3
Projects
None yet
2 participants