Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): support DEBUG and INFO logging levels for AppSync GraphQL APIs #31326

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Sep 5, 2024

Issue # (if applicable)

N/A

Reason for this change

AppSync now support DEBUG and INFO logging levels.

Announcement: AWS AppSync enhances API monitoring with new DEBUG and INFO logging levels

Description of changes

  • Added INFO and DEBUG to the FieldLogLevel enum.
  • Added README, unit tests, and integration tests for FieldLogLevel as they were missing.

Description of how you validated changes

Add unit tests and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 5, 2024 00:39
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 5, 2024
@@ -186,15 +186,23 @@ export interface AuthorizationConfig {
*/
export enum FieldLogLevel {
/**
* No logging
* Resolver logging is disabled
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the descriptions for existing levels (NONE, ERROR, and ALL) to be more user-friendly, aligning them with the AWS Management Console.

image

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 5, 2024
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Only comments on the docs.

packages/aws-cdk-lib/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 5, 2024
mazyu36 and others added 3 commits September 5, 2024 12:47
Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 5, 2024

@go-to-k
Thank you for the review.
I’ve incorporated the comments.

@mazyu36 mazyu36 requested a review from go-to-k September 5, 2024 04:23
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 5, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 6, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 31d17a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4b9643f into aws:main Sep 6, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Sep 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Sep 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
@mazyu36 mazyu36 deleted the appsync-new-log-level branch September 6, 2024 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants