Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lambda: npm package js not synced with ts #30908

Open
bataras opened this issue Jul 20, 2024 · 2 comments
Open

aws_lambda: npm package js not synced with ts #30908

bataras opened this issue Jul 20, 2024 · 2 comments
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. p3

Comments

@bataras
Copy link

bataras commented Jul 20, 2024

Describe the bug

  1. download the release aws-cdk-2.149.0.zip
  2. extrace js/aws-cdk-lib@2.149.0.jsii.tgz
  3. these two files don't seem to be in sync...
  • package/aws-lambda/lib/image-function.js
  • package/aws-lambda/lib/image-function.d.ts

The TS file has..

export declare class DockerImageFunction extends Function {
    constructor(scope: Construct, id: string, props: DockerImageFunctionProps);
}

The JS file has a version of this:

export class DockerImageFunction extends Function {

export class DockerImageFunction extends Function {
  constructor(scope: Construct, id: string, props: DockerImageFunctionProps) {
    super(scope, id, {
      ...props,
      handler: Handler.FROM_IMAGE,
      runtime: Runtime.FROM_IMAGE,
      code: props.code._bind(props.architecture),
    });
  }

Expected Behavior

files are in sync

Current Behavior

they are not in sync

Reproduction Steps

see description

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.149.0

Framework Version

No response

Node.js Version

v22.0.0

OS

macos

Language

TypeScript

Language Version

No response

Other information

No response

@bataras bataras added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2024
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jul 20, 2024
@pahud
Copy link
Contributor

pahud commented Jul 22, 2024

Can you explain what issues are you having using lambda.DockerImageFunction construct ?

@pahud pahud added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p3 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 22, 2024
@bataras
Copy link
Author

bataras commented Jul 22, 2024

There are no apparent issues running it.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. p3
Projects
None yet
Development

No branches or pull requests

2 participants