Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch: support multi-node job on Amazon EKS #30906

Open
1 of 2 tasks
mazyu36 opened this issue Jul 19, 2024 · 4 comments
Open
1 of 2 tasks

batch: support multi-node job on Amazon EKS #30906

mazyu36 opened this issue Jul 19, 2024 · 4 comments
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jul 19, 2024

Describe the feature

AWS batch now supports multi-node parallel jobs on Amazon EKS from Jul 11, 2024.
But L2 Construct does not support.

MultiNodeJobDefinition is only for multi-node jobs on Amazon ECS.

Use Case

To use multi-node jobs on Amazon EKS.

Proposed Solution

Add new class like MultiNodeEksJobDefinition.

Other Information

When addressing this issue, is submitting an RFC mandatory?

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.147.0

Environment details (OS name and version, etc.)

all

@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 19, 2024
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Jul 19, 2024
@pahud
Copy link
Contributor

pahud commented Jul 19, 2024

Thank you mazyu. We are looking forward to your PRs as always :)

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 19, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jul 20, 2024

I realized that this cannot be implemented at present.
EKS configuration is not yet supported in CloudFormation's NodeProperties.

Node properties can't be specified for Amazon EKS based job definitions.

We need to wait for CloudFormation to support this feature.

@delagoya
Copy link

delagoya commented Aug 28, 2024

This is supported by CloudFormation.

EKS properties are under NodeRangeProperties

@delagoya
Copy link

A comment on the above - it made sense to fold the Batch API construct NodeProperties.NodeRangeProperties[].container to NodeProperties.containers[] in the CDK L2 construct when you could only define a single container per NodeRange, but now that you can define multiple containers per NodeRange, the L2 construct should reflect the API more closely.

If a new MultiNodeEksJobDefinition class is created as part of the pull request, it makes more sense for the class to follow the API model and define a readonly nodeRanges: EksNodeRange[] property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants