-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codebuild: ARM images supports all compute types, incorrect validation #30869
Comments
Looks like as of last week ARM expanded to medium Xlarge and 2Xlarge compute types! See the table here. We should remove the validation, thanks for the call out @Samrose-Ahmed! Side note: it looks like reserved capacity fleets still have ARM compute types limited to small and large. Best to remove this validation to enable use, but something to keep in mind. |
I'd like to work on this issue. I've removed the code from the "Possible Solution" step. I've also removed the comment above it, suggesting the computeType must be How should I be handling the TS warning now that the |
@PeterEckIII, looks like that validate function is specific to ARM build images. Since there are now no restrictions on ARM compute types, the validation may not be necessary at all. |
@scanlonp, I amended my commit with some changes to test files, but it's still denying my PR due to no integration files being changed. I'm looking for any potentially affected files but am slow moving at the moment. If you know any integration files off the top of your head that I can adjust I will make that change. Otherwise, I'll keep digging. Thanks |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
Describe the bug
Theres is an incorrect validation here:
aws-cdk/packages/aws-cdk-lib/aws-codebuild/lib/linux-arm-build-image.ts
Line 115 in 9bd92da
ARM images only support ComputeTypes 'BUILD_GENERAL1_SMALL' and 'BUILD_GENERAL1_LARGE' - 'BUILD_GENERAL1_XLARGE' was given at PipelineProject.renderEnvironment
.ARM images support all compute types, this is probably outdated.
Expected Behavior
Should support all compute types.
Current Behavior
Only supports small and large.
Reproduction Steps
create codebuild arm project with compute type XLARGE
Possible Solution
Just remove this code:
aws-cdk/packages/aws-cdk-lib/aws-codebuild/lib/linux-arm-build-image.ts
Lines 112 to 116 in 9bd92da
Additional Information/Context
No response
CDK CLI Version
2.149.0 (build c8e5924)
Framework Version
No response
Node.js Version
18
OS
macos
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: