Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-kinesisfirehose-alpha): RedshiftDestination support #30866

Open
2 tasks
simonmarty opened this issue Jul 15, 2024 · 2 comments
Open
2 tasks

(aws-kinesisfirehose-alpha): RedshiftDestination support #30866

simonmarty opened this issue Jul 15, 2024 · 2 comments
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@simonmarty
Copy link

simonmarty commented Jul 15, 2024

Describe the feature

RedshiftDestinationConfigurationProperty (and others) takes a secretsManagerConfiguration object that contains the ARN of the secret.

It would be a better user experience if we could pass a Secret construct to it instead.

Use Case

See above. I'm from AWS Secrets Manager and have had customers reach out to me about the UX of this CDK construct.

Proposed Solution

Write L2 constructs for these resources.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.147.1

Environment details (OS name and version, etc.)

environment-independent.

@simonmarty simonmarty added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose label Jul 15, 2024
@simonmarty simonmarty changed the title (aws-kinesisfirehose-alpha): Provide L2 constructs for aws-kinesisfirehose-alpha (aws-kinesisfirehose-alpha): Pass a Secret construct to destination config properties Jul 15, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 16, 2024
@khushail khushail self-assigned this Jul 16, 2024
@khushail
Copy link
Contributor

khushail commented Jul 16, 2024

Hi @simonmarty , thanks for reaching out. Though Amazon Kinesis Data Firehose Alpha is experimental, am not really sure about making Secret a a construct to be passed here. But we are open to feedback from the community. Please help in prioritizing it by upvotes.

@khushail khushail added p3 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 16, 2024
@pahud pahud changed the title (aws-kinesisfirehose-alpha): Pass a Secret construct to destination config properties (aws-kinesisfirehose-alpha): RedshiftDestination support Jul 16, 2024
@pahud
Copy link
Contributor

pahud commented Jul 16, 2024

Hi

For all kinesis firehose destinations, they should be implemented in the destination library. At this moment, only S3bucket destination is implemented and we definitely need to implement the Redshift destination as well. By the time we implement that, we could use ISecret interface to represent the secret so we can get the secret arn from that interface.

Creating a new destination module is very straightforward, simply create a new destination class that implements firehose.IDestination with a bind method that returns all the configurations. Check here for more details.

I just changed this issue title for Redshift Destination support and we welcome the pull requests from the community.

@khushail khushail removed their assignment Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

3 participants