-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secretsmanager.RotationSchedule(): breaks cdk import #30854
Comments
Hi @steven-robbins , thanks for reaching out. I tried to repro the scenario and observed that by adding this block, the code started failing with imports as you mentioned above - const rotationSchedule = new secretsmanager.RotationSchedule(this, 'ExampleRotationSchedule', {
secret: secret,
hostedRotation: secretsmanager.HostedRotation.mysqlSingleUser(),
}); Although the issue is reproducible, I noticed that its mentioned in the docs that one has to add the transform-
is being executed which invokes the
|
This is snippet of synthesized template , the |
@steven-robbins , |
|
I'm not sure I would consider this bug addressed. Introducing secret rotation causes all resources in the stack to be considered an "unsupported resource type". This means the VPC and Secret resources cannot be imported. |
In order to use We should not resolve this, however, until the error messages have been addressed. |
Describe the bug
Secrets Manager RotationSchedule is causing all resources in the stack to be reported as "unsupported resource type" during cdk import.
Expected Behavior
Supported resources are able to be imported during cdk import
Current Behavior
Reproduction Steps
Possible Solution
No response
Additional Information/Context
It looks like this is the line that is causing all stack imports to fail.
Stack.of(scope).addTransform('AWS::SecretsManager-2020-07-23');
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts#L309
CDK CLI Version
2.148.1
Framework Version
No response
Node.js Version
v20.10.0
OS
MacOS 14.5
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: