Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cdk.aws_stepfunctions_tasks.HttpInvoke: Too much props required to make it work #30844

Open
boringContributor opened this issue Jul 12, 2024 · 2 comments
Labels
@aws-cdk/aws-stepfunctions-tasks bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@boringContributor
Copy link

Describe the bug

The HttpInvoke task requires too much information than actually needed, which makes the development much more complicated.

  1. It requires apiRoot and apiEndpoint. Why does it requires those separately? The SFN ASL Definition clearly allows only to pass the apiEndpoint.
  2. ConnectionARN: It should be possible to only pass a ConnectionARN, not require to also provide the SecretARN and ConnectionName.
image

Expected Behavior

Only the minimum amount of required props should be provided to make it work.

e.g. only paste the ApiEndpoint, only provide the ConnectionARN

Current Behavior

in order to specific an API, both, apiRoot AND apiEndpoint are required
in order to connect an event bridge connection a Connection.fromConnectionAttributes(...) is necessary which requires the ConnectionARN, SecretARN and the ConnectionName

Reproduction Steps

Import the HttpInvoke task and try to set it up.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.148.1

Framework Version

No response

Node.js Version

18

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

@boringContributor boringContributor added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
@ashishdhingra
Copy link
Contributor

@boringContributor Good morning. Thanks for opening the issue. Please review if this issue really a bug, or a proposal for feature request, or better Q&A discussion. Any changes to current design to the library needs to be evaluated in terms of whether it's a breaking change, traction from community, etc.

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
@boringContributor
Copy link
Author

hey @ashishdhingra thanks for the quick reply. Imho this is a bug. It clearly states that those properties are not required, still, the CDK Task made it required.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 12, 2024
@ashishdhingra ashishdhingra self-assigned this Jul 12, 2024
@ashishdhingra ashishdhingra added p2 effort/medium Medium work item – several days of effort labels Jul 19, 2024
@ashishdhingra ashishdhingra removed their assignment Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions-tasks bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants