Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codedeploy): zonal configuration for ServerDeploymentConfig #30429

Merged
merged 30 commits into from
Jul 8, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Jun 2, 2024

Issue # (if applicable)

Closes #30430

Reason for this change

ServerDeploymentConfig does not support for configuring the zonal configuration.

Description of changes

  • define ZonalConfig interface
  • define MinimumHealthyHostsPerZone class
  • add zonalConfig property to the BaseDeploymentConfigProps

Description of how you validated changes

Add both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 2, 2024 14:15
@github-actions github-actions bot added the feature-request A feature should be added or improved. label Jun 2, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review June 3, 2024 11:50
@badmintoncryer badmintoncryer marked this pull request as draft June 3, 2024 11:52
@badmintoncryer badmintoncryer marked this pull request as ready for review June 3, 2024 13:46
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 3, 2024
@badmintoncryer badmintoncryer marked this pull request as draft June 3, 2024 15:14
@badmintoncryer badmintoncryer marked this pull request as ready for review June 3, 2024 15:28
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Left some comments for adjustments

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 3, 2024
@badmintoncryer
Copy link
Contributor Author

@lpizzinidev Thank you for your review! I've addressed your comments.

@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented Jul 4, 2024

@paulhcsun Thank you for your review!! I've addressed your comments.

@paulhcsun paulhcsun added the pr/do-not-merge This PR should not be merged at this time. label Jul 4, 2024
paulhcsun
paulhcsun previously approved these changes Jul 4, 2024
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @badmintoncryer! I've approved the PR but added a do-not-merge label as we're currently holding off on merging anything while fixing a custom resources related issue which touches a lot of integ tests. This change probably would not affect that but we're pausing all merges temporarily to be safe. We should hopefully be able to get this merged in tomorrow if not sometime next week. Thanks for your patience and understanding! 🙏

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 4, 2024
@Leo10Gama Leo10Gama removed the pr/do-not-merge This PR should not be merged at this time. label Jul 5, 2024
Copy link
Contributor

mergify bot commented Jul 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor Author

@mergify update

Copy link
Contributor

mergify bot commented Jul 6, 2024

update

✅ Branch has been successfully updated

@mergify mergify bot dismissed paulhcsun’s stale review July 6, 2024 09:16

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 6, 2024
@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented Jul 6, 2024

@paulhcsun I've updated snapshots. So, could you please review this again?

Copy link
Contributor

mergify bot commented Jul 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 8, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a2a898f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit da0dc57 into aws:main Jul 8, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Jul 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the zonalConfig branch July 9, 2024 02:53
GavinZZ pushed a commit that referenced this pull request Jul 10, 2024
…30429)

### Issue # (if applicable)

Closes #30430

### Reason for this change

`ServerDeploymentConfig` does not support for configuring the [zonal configuration](https://docs.aws.amazon.com/codedeploy/latest/userguide/deployment-configurations-create.html#zonal-config).

### Description of changes

- define `ZonalConfig` interface
- define `MinimumHealthyHostsPerZone` class
- add `zonalConfig` property to the `BaseDeploymentConfigProps`

### Description of how you validated changes

Add both unit and integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codedeploy: zonal configuration for the EC2/on-premises deploy configuration
5 participants