feat(stepfunctions-tasks): add cpu and memory parameters to EcsRunTask

[kackyt]

Issue # (if applicable)

Closes #30027 .

Reason for this change

As described in the issue.

Description of changes

Add cpu and memoryMiB property to EcsRunTaskProps.

Description of how you validated changes

Add unit tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[kackyt]

Review please!

[pahud]

Hi

This PR has been pending for community review for a while. Please consider posting it on the #contributing channel in cdk.dev. Community members will be on the lookout there as well for possible reviews.

Check How to get your P2 PR community reviewed for more details.

[tmokmss]

Thanks for the PR! I left some comments but otherwise LGTM.

[tmokmss]

To the maintaners: can you confirm the decision made here? Or let us know if there are other options 🙏

[shikha372]

Thanks @kackyt for submitting the PR, want to be double sure that we're not adding the functionality that can already be achieved with the help of container override. Could you help in providing a specific use case of ECS run task where this was not working for you. If you've a code snippet that you're using that would help too.

[kackyt]

@shikha372

This is useful when you want to allocate resources flexibly according to the data set used in EcsTask, or when you want to increase memory when retrying from errors such as OOM.Furthermore, in Fargate Task, this parameter is required to specify the size. We cannot change the size of the Fargate with container override.

[shikha372]

Thanks @kackyt, checked the differences with the deployment, i'm not sure i completely agree with statement that it is not supported in Fargate Cluster nor i found any documentation stating that, I see overrides getting populated in the state machine definition for both EC2 and Fargate, let me know if i'm missing something here. Here is the code snippet:

        "TaskDefinition": "ECREc2StackTD10AFFC0F",
        "Overrides": {
          "ContainerOverrides": [
            {
              "Name": "TheContainer",
              "Cpu": 512,
              "Memory": 1024,
              "Environment": [
                {
                  "Name": "SOME_KEY",
                  "Value.$": "$.SomeKey"
                }
              ]
            }
          ]
        },
        "LaunchType": "EC2"

        "Overrides": {
          "ContainerOverrides": [
            {
              "Name": "TheContainer",
              "Cpu": 512,
              "Memory": 1024,
              "Environment": [
                {
                  "Name": "SOME_KEY",
                  "Value.$": "$.SomeKey"
                }
              ]
            }
          ]
        },
        "LaunchType": "FARGATE",
        "PlatformVersion": "1.4.0"

That being said, adding these values help to override the cpu and memory set at task definition level which i don't think exist today, and would review PR for that requirement.

Task override:

        "Overrides": {
          "Cpu": "1024",
          "Memory": "2048",
          "ContainerOverrides": [
            {
              "Name": "TheContainer",
              "Environment": [
                {
                  "Name": "SOME_KEY",
                  "Value.$": "$.SomeKey"
                }
              ]
            }
          ]
        },
        "LaunchType": "FARGATE",

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5d8447e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.