prlint: assess needs review after codebuild job succeeds #30128
Labels
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
package/tools
Related to AWS CDK Tools or CLI
Describe the bug
We refuse to assess if a PR needs review if the codebuild job is not successful. However if the pr linter runs before the codebuild job is done, it will not run again until another triggering action happens on the PR. So a situation like this might happen:
We would like this situation to still get labeled
needs-maintainer-review
after the build is successful, but instead it will not report anything until the next trigger.Expected Behavior
see above
Current Behavior
see above
Reproduction Steps
see above
Possible Solution
We need the codebuild job to trigger the pr linter somehow. A possible solution is to modify the github workflow to trigger on
issue_comment
as well, and filter comments for the specific one that comes from aws-cdk-automation when the build succeeds. However, this likely opens prlinter to run on all prs and issues, albeit it will skip all jobs for non prs. That might be non tenable.Alternatively, we can finangle the codebuild step to hit one of the PR triggers when successful, like adding a new label.
Additional Information/Context
No response
CDK CLI Version
2.x
Framework Version
No response
Node.js Version
20
OS
Mac
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: