Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-logs): Add metric methods for log group IncomingLogEvents and IncomingBytes #30034

Closed
1 of 2 tasks
yattoni opened this issue May 1, 2024 · 3 comments · Fixed by #31535
Closed
1 of 2 tasks

(aws-logs): Add metric methods for log group IncomingLogEvents and IncomingBytes #30034

yattoni opened this issue May 1, 2024 · 3 comments · Fixed by #31535
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@yattoni
Copy link
Contributor

yattoni commented May 1, 2024

Describe the feature

Add metric methods for log group IncomingLogEvents and IncomingBytes, similar to existing metric methods like metricInvocations on Lambda functions.

https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CloudWatch-Logs-Monitoring-CloudWatch-Metrics.html

Use Case

Create alarms on log ingestion to ensure it is working.

Proposed Solution

Create metricIncomingLogEvents and metricIncomingBytes and maybe a generic metric methods on the LogGroup class similar to other resources with metric* methods.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.139.1

Environment details (OS name and version, etc.)

Amazon Linux 2

@yattoni yattoni added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 1, 2024
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label May 1, 2024
@khushail khushail changed the title (logs): Add metric methods for log group IncomingLogEvents and IncomingBytes (aws-logs): Add metric methods for log group IncomingLogEvents and IncomingBytes May 1, 2024
@ashishdhingra ashishdhingra self-assigned this May 1, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 1, 2024
@ashishdhingra
Copy link
Contributor

Perhaps needs to be implemented using guideline at https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#metrics.

@yattoni Thanks for submitting feature request. Feel free to contribute a PR which could be reviewed by the team.

Thanks,
Ashish

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 2, 2024
@ashishdhingra ashishdhingra removed their assignment May 14, 2024
@mergify mergify bot closed this as completed in #31535 Sep 25, 2024
@mergify mergify bot closed this as completed in 2813eb2 Sep 25, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
2 participants