-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_signer: Adding tags to stack containing signing profile causes errors on deployment #30013
Comments
@cjhelloletsgo , thanks for reporting this. I am able to repro the error. I also tried adding tags to existing bucket , to check if this is an issue with tags propagation but it worked fine and tags were added succesfully Marking this issue as appropriate for further action. |
It is 100% able to be reproduced. Here is a link to a github repo i set up: https://github.com/cjhelloletsgo/cdk_signing_profile_issue Just clone and deploy the stack. After it is deployed look in app.py and I put a comment where you need to uncomment and perform a second deployment. It will fail with this error: |
I just realized I lack reading comprehension and you wrote you could reproduce rather than couldn't. So my last comment can be ignored. My bad. |
This error seems to be resolved with newer CDK version 2.157.0 (build 7315a59) |
Comments on closed issues and PRs are hard for our team to see. |
Describe the bug
Deploying a stack with a signing profile then adding a tag to the stack will cause the deployment to fail with an internal error
Expected Behavior
The stack to deploy and tag the resource
Current Behavior
EthicsStack: deploying... [1/1]
EthicsStack: creating CloudFormation changeset...
10:59:26 AM | UPDATE_FAILED | AWS::Signer::SigningProfile | SigningProfile39EF76F3
Resource handler returned message: "null" (RequestToken: 1f53d8b0-de7b-c9a4-85ab-1d9754840f0f, HandlerErrorCode: InternalFailure)
❌ EthicsStack failed: Error: The stack named EthicsStack failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "null" (RequestToken: 1f53d8b0-de7b-c9a4-85ab-1d9754840f0f, HandlerErrorCode: InternalFailure)
at FullCloudFormationDeployment.monitorDeployment (/home/colton/.nvm/versions/node/v20.12.2/lib/node_modules/aws-cdk/lib/index.js:433:10568)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Object.deployStack2 [as deployStack] (/home/colton/.nvm/versions/node/v20.12.2/lib/node_modules/aws-cdk/lib/index.js:436:199619)
at async /home/colton/.nvm/versions/node/v20.12.2/lib/node_modules/aws-cdk/lib/index.js:436:181341
❌ Deployment failed: Error: The stack named EthicsStack failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "null" (RequestToken: 1f53d8b0-de7b-c9a4-85ab-1d9754840f0f, HandlerErrorCode: InternalFailure)
at FullCloudFormationDeployment.monitorDeployment (/home/colton/.nvm/versions/node/v20.12.2/lib/node_modules/aws-cdk/lib/index.js:433:10568)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Object.deployStack2 [as deployStack] (/home/colton/.nvm/versions/node/v20.12.2/lib/node_modules/aws-cdk/lib/index.js:436:199619)
at async /home/colton/.nvm/versions/node/v20.12.2/lib/node_modules/aws-cdk/lib/index.js:436:181341
The stack named EthicsStack failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "null" (RequestToken: 1f53d8b0-de7b-c9a4-85ab-1d9754840f0f, HandlerErrorCode: InternalFailure)
Reproduction Steps
Deploy a stack which contains a signing profile, then add a tag to the stack. The stack will fail to deploy with the above error.
The text was updated successfully, but these errors were encountered: